Bundle javax.mail:mail for JDK support#163
Open
reftel wants to merge 1 commit into
Open
Conversation
Author
jhansche
approved these changes
Apr 3, 2024
Author
|
Thanks for the review! How can we proceed to get this merged and released? |
|
LGTM (with manual substitution of the deps in the install folder, it fixes current version...) |
|
Rebuilding plugin with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles
javax.mail:mail, which is no longer included with the JVM.Testing done
Ran a pipeline that uses the
publishConfluencestep on a Jenkins running on JVM 17 with release163.vf906edb_73cceof confluence-publisher-plugin. The pipeline failed with aClassNotFoundExceptiondue to not findingjavax.mail.MessagingException. Made a local build of the same release, but with this patch applied. Re-ran the pipeline. This time, it worked.Also ran
com.sun.jersey.spi.service.ServiceFinder.find(javax.ws.rs.ext.MessageBodyReader.class, true).toClassArray()in the Script Console of the same Jenkins instance. With release163.vf906edb_73cce, it failed with aClassNotFoundExceptiondue tojavax.mail.MessagingExceptionnot existing. With this change, no exception was thrown.