Skip to content

Throw checked exception when password authentication fails #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krisstern merged 1 commit into from
May 14, 2026
Merged

Throw checked exception when password authentication fails #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,16 +470,14 @@ public Authentication authenticate(Authentication authentication) throws Authent
if (authentication instanceof GitLabAuthenticationToken) {
return authentication;
}
if (authentication instanceof UsernamePasswordAuthenticationToken) {
if (authentication instanceof UsernamePasswordAuthenticationToken token) {
try {
UsernamePasswordAuthenticationToken token =
(UsernamePasswordAuthenticationToken) authentication;
GitLabAuthenticationToken gitlab = new GitLabAuthenticationToken(
token.getCredentials().toString(), getGitlabApiUri(), TokenType.PRIVATE);
SecurityContextHolder.getContext().setAuthentication(gitlab);
return gitlab;
} catch (GitLabApiException e) {
throw new RuntimeException(e);
throw new BadCredentialsException("Authentication failed", e);
}
}
throw new BadCredentialsException("Unexpected authentication type: " + authentication);
Expand Down
Loading