Skip to content

Remove usages of Commons Lang 2 - #35

Open
timja-bot wants to merge 1 commit into
jenkinsci:masterfrom
timja-bot:commons-lang3
Open

Remove usages of Commons Lang 2#35
timja-bot wants to merge 1 commit into
jenkinsci:masterfrom
timja-bot:commons-lang3

Conversation

@timja-bot

Copy link
Copy Markdown

No need to depend on a third-party library here when the Java Platform provides this
functionality natively.

Part of the effort to remove Commons Lang 2 from Jenkins core — jenkinsci/jenkins#16404,
jenkinsci/jenkins#26105. Commons Lang 2 is EOL and carries an unfixed advisory
(GHSA-j288-q9x7-2f5v).

What's changed

  • DetailLinkDescription: the two StringUtils.isNotBlank calls become null checks plus
    trim().isEmpty(). (String.isBlank() would be neater but this plugin still compiles at Java 8.)
  • No dependency was added — this plugin did not declare Commons Lang, it came in transitively from
    core.

Testing done

mvn -B -ntp clean verify passes locally on Java 21 / macOS.

The ban-commons-lang-2 enforcer rule was left disabled: it needs parent POM 6.2116.v7501b_67dc517 or newer, and parent 6.x requires Jenkins 2.475+
(Jakarta EE 9) while this plugin targets 2.319.3.

Note: mvn clean verify needs JDK 17 here — on JDK 21 maven-license-plugin 1.10 fails with
Unsupported class file major version 65, unrelated to this change.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

🤖 This pull request was generated with AI assistance (Claude Code) as part of a bulk migration
across Jenkins plugins. If anything here looks wrong, please comment on this PR or contact @timja.

@timja
timja requested a review from a team August 4, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants