[JENKINS-12092] Block job by category

[fluffy88]

Allow categories to be configured so they are blocking by another category.

In category configuration, add new textbox which takes a comma separated list of category names. Jobs in the category will then be blocked from executing while jobs from any of the listed categories are queued or executing.

[fluffy88]

Sorry accidentally made this pull request too early.
I have to add new tests for the new functionality and now fix the ones I broke.

Comments on the Jira ticket or pull request are welcome though :)

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[fluffy88]

This is ready for review and merging

[oleg-nenashev]

Please save the previous constructor as well. Otherwise the change affects the binary compatibility with previous versions

[fluffy88]

Woohoo, fixed build failures :)
Sorry about the long delay

[fluffy88]

@oleg-nenashev any chance of a review for this PR?

[oleg-nenashev]

project.isBuilding() is unreliable for parallel runs; project.isInQueue() causes a full queue lookup with a serious performance impact on cores till 1.610

[oleg-nenashev]

@fluffy88
Currently I would put the change on hold, because it forces Queue checks for every project and every category => serious performance impact on 1.580.x LTS

We tried to somehow overcome the issue in #27 and #28 , but unfortunately now I have no time to finalize and especially test these changes.

[fluffy88]

👍 that's okay with me

[Karanval]

Any chance of this coming out?

[oleg-nenashev]

1.580.x compatibility is no longer a blocker, hence probably it could be done

[sp-ricard-valverde]

This would be a nice addition.

In my use case I have build jobs and node provisioning jobs, both with their respective categories.

The build and provisioning category should be able to do concurrent builds with a maximum of 1 per node.

When a provisioning category job runs it should block the build category on a node, so no other build or provisioning category job is running on any other executor for the particular node.

This PR is the best fit for this scenario.
I tried to accomplish this with other plugins but I couldn't find a good match, just this old Exclusive Execution but as I am using Jekins Config as Code it was a no-go.