add support for limiting job concurrency based on one or more build parameters by joemiller · Pull Request #9 · jenkinsci/throttle-concurrent-builds-plugin

joemiller · 2013-10-30T23:12:19Z

Submitting this PR to see if this feature set is something the upstream would be in favor of accepting. And if so, what changes or cleanup would be necessary to get it upstream?

…parameters basic support for limiting concurrent job runs by parameters

Selectable parameters

…kins config reload.

cloudbees-pull-request-builder · 2013-10-30T23:12:49Z

plugins » throttle-concurrent-builds-plugin #6 FAILURE
Looks like there's a problem with this pull request

jenkinsadmin · 2013-10-31T00:03:48Z

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

oleg-nenashev · 2013-11-04T20:20:32Z

Could you reduce version dependency to 1.480.x at least? Old LTS releases still alive...

Yes, I'll try that.

On Mon, Nov 4, 2013 at 12:20 PM, Oleg Nenashev notifications@github.comwrote:

In pom.xml:

@@ -26,13 +26,13 @@ THE SOFTWARE.

org.jenkins-ci.plugins
plugin

1.399

1.518

Could you reduce version dependency to 1.480.x at least? Old LTS releases
still alive...

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/9/files#r7412031
.

Upstream

cloudbees-pull-request-builder · 2014-02-21T00:50:07Z

plugins » throttle-concurrent-builds-plugin #17 FAILURE
Looks like there's a problem with this pull request

cloudbees-pull-request-builder · 2014-02-21T01:45:10Z

plugins » throttle-concurrent-builds-plugin #18 UNSTABLE
Looks like there's a problem with this pull request

fix npes

cloudbees-pull-request-builder · 2014-02-24T23:41:18Z

plugins » throttle-concurrent-builds-plugin #23 UNSTABLE
Looks like there's a problem with this pull request

Fix tests failures

cloudbees-pull-request-builder · 2014-03-20T23:15:08Z

plugins » throttle-concurrent-builds-plugin #28 SUCCESS
This pull request looks good

joemiller · 2014-03-20T23:24:34Z

this should be good to go now.

joemiller · 2014-04-04T17:29:18Z

@oleg-nenashev do you have access to review and merge this PR? Thanks

oleg-nenashev · 2014-04-04T17:44:12Z

@joemiller , @Hornswoggles
I'll review changes and provide my feedback.
BTW, I think that @abayer could make the final decision if he has some time to review the project.

From my point of view it makes sense to create a ThrottleCategoryProvider extension point. There are many possible sources of categories, so a generic approach would be very useful.

oleg-nenashev · 2014-04-04T17:45:51Z

Do we really need to change the version? I don't see real dependencies from Jenkins core.
I also recommend to avoid 1.509.4 at least. See https://groups.google.com/forum/#!topic/jenkinsci-dev/9fMrUsVh6zU

I am not sure, possibly. It's been a while since we started this patch and
I don't recall if we bumped version for a reason.

Would the proper approach to testing this be to simply revert the version
in the pom.xml and run the test suite?

thanks

On Fri, Apr 4, 2014 at 10:46 AM, Oleg Nenashev notifications@github.comwrote:

In pom.xml:

@@ -26,7 +26,7 @@ THE SOFTWARE.

org.jenkins-ci.plugins
plugin

1.424

1.509.4

Do we really need to change the version? I don't see real dependencies
from Jenkins core.
I also recommend to avoid 1.509.4 at least. See
https://groups.google.com/forum/#!topic/jenkinsci-dev/9fMrUsVh6zU

Reply to this email directly or view it on GitHubhttps://github.com//pull/9/files#r11305151
.

Test suites don't provide enough test coverage. BTW, it is better than nothing

Throttling by parameter doesnt work on 1.424 I will go through each LTS release between 1.424 and 1.509. Starting with 1.424.6

LTS 1.447 builds and works. Although the helpful message does not show up in the queue
LTS 1.466 builds and works and has the helpful message in the queue

varosi · 2015-09-16T09:58:20Z

Do you plan to merge those changes about controlling throttleling based on build parameters?

jenkinsci#9

jmozmoz · 2015-10-24T22:22:38Z

I merge the current master branch into this pull request and tried to follow the review comments in this pull request. These I do not know how to implement:

It also makes sense to use formatted outputs to prevent string constructions
It makes sense to add the parameter validation to UI form. Otherwise, errors in data formats may be left unnoticed
~~I suggest to calculate the array and save it to a transient field once (on save/load) to decrease the performance impact~~
Store a list instead of the string to avoid multiple parsings. I also think that the field name is quite confusing
isAnotherBuildWithSameParametersRunningOnAnyNode() has its internal logging of conflicts (there seems to be no loggin in isAnotherBuildWithSameParametersRunningOnAnyNode)
Please use Sun/Oracle Java code style to prevent complains from FindBugs and other utilities

If you give me more specific guidance how to fix these, I will try to implement them also.

Here is the repository: https://github.com/jmozmoz/throttle-concurrent-builds-plugin

jmozmoz · 2015-11-02T23:54:39Z

Ping
Is there a chance to get update of the original pull request into this plugin? Anybody willing to help?

oleg-nenashev · 2015-12-12T10:19:47Z

@varosi @jmozmoz
This PR would be eligible for the merge when the performance issues get solved.
1.609.x LTS already provides some changes in this direction, but not enough IMHO.

Ignas · 2016-01-07T17:06:18Z

Which performance issues exactly have to be solved? I can't find any of them being discussed in comments on this pull request.

jmozmoz · 2016-01-08T14:02:04Z

As requested a I move the list paramsToCompare to a transient field which is filled by an overwritten load()/save()?
See the commit jmozmoz@599453b in pantheon-deprecated#6

Is this the way to go?

oleg-nenashev · 2016-01-08T14:17:12Z

@Ignas E.g. https://issues.jenkins-ci.org/browse/JENKINS-27650

oleg-nenashev · 2016-01-08T14:20:42Z

@jmozmoz

As requested a I move the list paramsToCompare to a transient field which is filled by an overwritten load()/save()?

Yes, it may work. I've lost the track of this PR a bit, need to review it again. Did you have a chance to process the previous comments?

jmozmoz · 2016-01-10T01:01:02Z

I created a new pull request #33 including upstream changes not merged into in this original pull request. Also I think I addressed the following issues (striked out):

~~I suggest to calculate the array and save it to a transient field once (on save/load) to decrease the performance impact~~
~~Store a list instead of the string to avoid multiple parsings. I also think that the field name is quite confusing~~ (this was already fixed (the list), also the string has been renamed)
~~isAnotherBuildWithSameParametersRunningOnAnyNode() has its internal logging of conflicts~~
~~Please use Sun/Oracle Java code style to prevent complains from FindBugs and other utilities~~
It also makes sense to use formatted outputs to prevent string constructions
It makes sense to add the parameter validation to UI form. Otherwise, errors in data formats may be left unnoticed
(the last two issues remain: Could somebody please point me to examples how to fix them)

jmozmoz · 2016-01-10T16:09:27Z

Now the pull request #33 builds but there are some test failures. I have no idea, how these test failures are related to the work here. Could somebody please help.

zoidyzoidzoid · 2016-04-13T09:40:46Z

Can this PR be closed since #38 has been merged?

joemiller added 7 commits February 25, 2013 14:10

basic support for limiting concurrent job runs by parameters

766475a

Merge pull request #1 from pantheon-systems/limit_concurrency_by_job_…

931f183

…parameters basic support for limiting concurrent job runs by parameters

allow limiting job concurrency against a list of parameters

75a1598

added some quick commands to help other devs work on the plugin

07d2291

Merge pull request #2 from pantheon-systems/selectable_parameters

65bc248

Selectable parameters

fix bug with jenkins >1.510 causing stackoverflow. bump version

05b8ed7

fix bug where parameter-based job concurrency stops working after jen…

0be7eff

…kins config reload.

oleg-nenashev reviewed Nov 4, 2013
View reviewed changes

Hornswoggles added 4 commits February 20, 2014 14:39

Successful build against 1.509.4

d8d2017

merging in 1.8.1 upstream changes

8319b20

Fixing NPE

f4c0ce2

Merge pull request #3 from pantheon-systems/upstream

ed78fdb

Upstream

Hornswoggles added 2 commits February 20, 2014 17:40

updating tests so they pass

805556e

Merge branch 'upstream'

a01b866

Kyle Ibrahim and others added 3 commits February 24, 2014 15:23

fix npes

801200e

helper function

77ad29d

Merge pull request #4 from pantheon-systems/fix_npe_again

3421a91

fix npes

Zihao Yu added 2 commits March 19, 2014 12:54

replace deprecated method

7520a2c

fix test by changing select options to upper case

12b7aac

zihaoyu mentioned this pull request Mar 19, 2014

Fix tests failures pantheon-deprecated/throttle-concurrent-builds-plugin#5

Merged

Zihao Yu and others added 3 commits March 19, 2014 13:26

add .idea directory to .gitignore

1a32b7d

fix comment typo

cc0da5a

Merge pull request #5 from zihaoyu/develop

5284d6d

Fix tests failures

oleg-nenashev reviewed Apr 4, 2014
View reviewed changes

jmozmoz added a commit to jmozmoz/throttle-concurrent-builds-plugin that referenced this pull request Oct 24, 2015

Implement (most) review requests in

d200a57

jenkinsci#9

jmozmoz mentioned this pull request Jan 10, 2016

Add support for limiting job concurrency based on one or more build parameters (replaces pull request #9) #33

Closed

Uh oh!

Conversation

joemiller commented Oct 30, 2013

Uh oh!

cloudbees-pull-request-builder commented Oct 30, 2013

Uh oh!

jenkinsadmin commented Oct 31, 2013

Uh oh!

oleg-nenashev Nov 4, 2013

Choose a reason for hiding this comment

Uh oh!

joemiller Nov 4, 2013

Choose a reason for hiding this comment

Uh oh!

cloudbees-pull-request-builder commented Feb 21, 2014

Uh oh!

cloudbees-pull-request-builder commented Feb 21, 2014

Uh oh!

cloudbees-pull-request-builder commented Feb 24, 2014

Uh oh!

cloudbees-pull-request-builder commented Mar 20, 2014

Uh oh!

joemiller commented Mar 20, 2014

Uh oh!

joemiller commented Apr 4, 2014

Uh oh!

oleg-nenashev commented Apr 4, 2014

Uh oh!

oleg-nenashev Apr 4, 2014

Choose a reason for hiding this comment

Uh oh!

joemiller Apr 4, 2014

Choose a reason for hiding this comment

Uh oh!

oleg-nenashev Apr 4, 2014

Choose a reason for hiding this comment

Uh oh!

Hornswoggles Apr 4, 2014

Choose a reason for hiding this comment

Uh oh!

Hornswoggles Apr 4, 2014

Choose a reason for hiding this comment

Uh oh!

varosi commented Sep 16, 2015

Uh oh!

jmozmoz commented Oct 24, 2015

Uh oh!

jmozmoz commented Nov 2, 2015

Uh oh!

oleg-nenashev commented Dec 12, 2015

Uh oh!

Ignas commented Jan 7, 2016

Uh oh!

jmozmoz commented Jan 8, 2016

Uh oh!

oleg-nenashev commented Jan 8, 2016

Uh oh!

oleg-nenashev commented Jan 8, 2016

Uh oh!

jmozmoz commented Jan 10, 2016

Uh oh!

jmozmoz commented Jan 10, 2016

Uh oh!

zoidyzoidzoid commented Apr 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants