Default bottom keybindings line text to white for dark terminals#5598
Open
zhenrenbumeng wants to merge 1 commit into
Open
Default bottom keybindings line text to white for dark terminals#5598zhenrenbumeng wants to merge 1 commit into
zhenrenbumeng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the default gui.theme.optionsTextColor from blue to white.
The bottom bar shows keybinding hints; previously it defaulted to ANSI blue (optionsTextColor: ["blue"]). On the most common setup—palette-based dark/black terminal background plus no special tweaking—this is effectively dark/low-luminance saturated blue glyphs on black, which performs very poorly for legibility compared to lighter neutrals like white.
From a perceptual/contrast standpoint: readable text relies on sufficient luminance contrast between foreground and background, not hue alone. On a nearly black background, blue has intrinsically low luminance relative to colours like yellow, cyan, or white: the perceived brightness stays low unless the palette uses a consciously “bright/high-luminance blue”. Many default 16‑colour palettes do not strongly boost blue’s luminance, so the foreground sits close to the background in lightness. That sharply reduces discriminability—especially at a glance, in peripheral vision, on smaller fonts, or for users whose colour vision skews differentiation between saturated blues (not rare), where hue difference does not reliably rescue readability when lightness contrast is marginal.
ANSI “blue-on-black” is a well‑known readability pain point in TUIs compared to pale grey/white; defaulting keybinding help to white matches the expectation that ancillary UI chrome should remain legible across stock terminals without forcing every user into custom theme overrides.
Behaviour when users explicitly set optionsTextColor in config is unchanged; only defaults and docs/schema are updated accordingly.