Remove foreigner gem - #4
Open
tscholz wants to merge 2 commits into
Open
Conversation
Owner
|
This PR has a merge conflict. I'm also not sure I'm comfortable removing the foreigner requirement, particularly without adding model level hooks to accomplish the same goal. The existing foreign key relationships cascade deletes, and there's nothing here to support that. |
Author
|
Thank you for the review and your feedback. The merge conflict is solved. Not sure if I miss something but I think activerecord already cascade deletes as specified here. |
Owner
|
Thanks! I'm going to have another member of our engineering org take a look to verify functionality. Standby! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
we run into the same issue as described here when running our test suite on Rails 3.2. Unfortunately it is not an option for us to disable triggers in our test env at all as we have tests/features depending on postgres triggers. As there is no clean way to deal with this I'd suggest to drop foreign keys and the dependancy to the foreigner gem, at least for rails 3 versions.