fix(#683): trap keyboard focus within AnchorSelector dropdown#3
Open
jessicanath wants to merge 1 commit into
Open
fix(#683): trap keyboard focus within AnchorSelector dropdown#3jessicanath wants to merge 1 commit into
jessicanath wants to merge 1 commit into
Conversation
Intercept Tab/Shift+Tab when the dropdown is open to cycle focus through options instead of allowing it to escape the dropdown. Closes Haroldwonder#683
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes Haroldwonder#683
Changes
AnchorSelector.tsx, theTabkey handler now callse.preventDefault()and cycles focus forward through dropdown optionsShift+Tabcycles focus backwardEscapestill closes it and returns focus to the trigger button