Skip to content

Comments

feat: display hostname in browser tab and nav bar#1163

Open
DiamondCortex wants to merge 1 commit intojetkvm:devfrom
DiamondCortex:feat/display-hostname
Open

feat: display hostname in browser tab and nav bar#1163
DiamondCortex wants to merge 1 commit intojetkvm:devfrom
DiamondCortex:feat/display-hostname

Conversation

@DiamondCortex
Copy link

@DiamondCortex DiamondCortex commented Jan 28, 2026

Closes #83 #528

Summary

This feature helps users with multiple JetKVM devices quickly identify which device a browser tab belongs to. The hostname appears in the browser tab title (format: "{hostname} - JetKVM") and in the navigation bar next to the logo. Users can enable this via a checkbox in Network settings, which is off by default to avoid disrupting existing workflows.

Checklist

  • Ran make test_e2e locally and passed
  • Linked to issue(s) above by issue number (e.g. Closes #<issue-number>)
  • One problem per PR (no unrelated changes)
  • Lints pass; CI green
  • Tricky parts are commented in code
Image Screenshot 2026-01-27 at 8 55 18 PM

This feature helps users with multiple JetKVM devices quickly identify which device a browser tab belongs to. The hostname appears in the browser tab title (format: "{hostname} - JetKVM") and in the navigation bar next to the logo. Users can enable this via a checkbox in Network settings, which is off by default to avoid disrupting existing workflows.
@CLAassistant
Copy link

CLAassistant commented Jan 28, 2026

CLA assistant check
All committers have signed the CLA.

setHdmiState(hdmiState);
});

console.log("Requesting network settings");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be deleted or changed to console.debug(

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mimicking the same behavior as the request right above at line 770. I can remove the log statement if you think its unnecessary though

@BDworak
Copy link

BDworak commented Feb 15, 2026

Looking forward to this change merging :). Thanks for implementing @DiamondCortex

@adamshiervani
Copy link
Contributor

Thanks for taking the time to making the PR!

Let's simplify this: remove the configuration, and set the document title and show it in the header, if the user has overridden the default (jetkvm-xxxxx) hostname. It's not a complete solution, but good until we have time to implement a proper solution.

The proper solution would be to implement a separate on-device "name" property and remove the cloud-api device name, which is causing a real conflict. We currently use the cloud-api device name to list the devices, but instead of using the cloud-api database, we could simply just ask the device what the on-device "name" is and just render that. We already ask for the version number every time we list the devices in the cloud dashboard, so shouldn't be a big problem. To tie it all together, we could add an onboarding step asking the user to name the device from the start.

This would be a "proper" implementation and clean up some debt, but as this touches the cloud-api, websocket signaling, UI, I understand if third-party contributors don't have time to tackle this. Unfortunately, I don't either, right now.

Anyway, just do the removal of the configuration, and I'll merge it into dev. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to Rename a JetKVM

5 participants