Fix possible heap buffer overflow in argon2i_32#20
Merged
Conversation
* Added Python 3.14 to setup.py * Bumped GitHub actions versions. * Fixed debian package build to run after python release. * Updated changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A heap buffer overflow (write) exists in the argon2i_32() function in c_monocypher.pyx. The nb_blocks parameter is accepted directly from the caller and passed to the underlying crypto_argon2() C function without validation. When nb_blocks is less than 8, the internal Argon2 implementation performs a heap write 1024 bytes past the end of the allocated work area, resulting in memory corruption.
Thank you Haris (hextheshadow) for the vulnerability report & fix.