added Grunt and jshint'ed the JS code#3
Conversation
juanbrujo
commented
Oct 17, 2014
- changed the repo structure.
- added Grunt and JS code revised with jshint.
- better demo, more descriptive tests
change the repo structure, added grunt and revised with jshint.
now demo calls the min.js file and they’re more descriptive
|
Why did you remove so much code from docreadytest.html? |
|
I noticed you weren't using your docready.js with the demo, so I added it to docreadytest.html and made your tests run with it. |
|
That's perfectly fine to include docready.js into the test page instead of the copy of the code that it had, but you removed a lot of test code too so that now the file doesn't run nearly as many tests as it was. I was wondering why you did that? |
|
I guess I missed some of your test trying to clean the docreadytest.htmt, as I read in your code the valuable tests were the ones regarding the DOM manipulation (and not the log) |
|
The tests were designed to log when various events happened relative to one another so one could see that docReady is firing at the right time relative to other things going on in all sorts of different browsers. |