Skip to content

added Grunt and jshint'ed the JS code#3

Open
juanbrujo wants to merge 2 commits into
jfriend00:masterfrom
juanbrujo:master
Open

added Grunt and jshint'ed the JS code#3
juanbrujo wants to merge 2 commits into
jfriend00:masterfrom
juanbrujo:master

Conversation

@juanbrujo
Copy link
Copy Markdown

  • changed the repo structure.
  • added Grunt and JS code revised with jshint.
  • better demo, more descriptive tests

juanbrujo added 2 commits October 17, 2014 17:17
change the repo structure, added grunt and revised with jshint.
now demo calls the min.js file and they’re more descriptive
@jfriend00
Copy link
Copy Markdown
Owner

Why did you remove so much code from docreadytest.html?

@juanbrujo
Copy link
Copy Markdown
Author

I noticed you weren't using your docready.js with the demo, so I added it to docreadytest.html and made your tests run with it.

@jfriend00
Copy link
Copy Markdown
Owner

That's perfectly fine to include docready.js into the test page instead of the copy of the code that it had, but you removed a lot of test code too so that now the file doesn't run nearly as many tests as it was. I was wondering why you did that?

@juanbrujo
Copy link
Copy Markdown
Author

I guess I missed some of your test trying to clean the docreadytest.htmt, as I read in your code the valuable tests were the ones regarding the DOM manipulation (and not the log)

@jfriend00
Copy link
Copy Markdown
Owner

The tests were designed to log when various events happened relative to one another so one could see that docReady is firing at the right time relative to other things going on in all sorts of different browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants