Open
Conversation
eranturgeman
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Enable static SCA tests and fix test error handling
Summary
Re-enable static SCA integration tests that were previously globally skipped due to remediation API unavailability (now resolved). Update
testAuditCommandNewScato return errors alongside output, allowing proper validation of fail-build behavior in violation tests. Add targeted skip guards for two known Xray bugs (XRAY-135832, XRAY-136444) instead of blanket-skipping all new SCA tests.Changes
audit_test.go: ChangedtestAuditCommandNewScato return(string, error)(viaRunCliCmdWithOutputs), updated all callers to handle the error.TestAuditNewScaSimpleJsonViolationsnow asserts the expectedExitCodeVulnerableBuildCLI error. Added skip guard onTestAuditNewScaCycloneDxNpmfor XRAY-135832. Updated Gradle expected counts (10→11 vulns, 6→7 components) and npm SBOM component breakdown (direct/transitive split).git_test.go: Added skip guard onTestGitAuditStaticScaCycloneDxfor XRAY-136444. Removed unnecessaryWithSbomparam from the git static SCA test.go.mod: Promotedgolang.org/x/sysfrom indirect to direct dependency.tests/utils/integration/test_integrationutils.go: Removed the global skip guard fromInitAuditNewScaTestssince the remediation API issue is resolved.devbranch.go vet ./....go fmt ./....