Skip to content

Enable Static Sca tests#680

Open
attiasas wants to merge 9 commits intojfrog:devfrom
attiasas:enable_static_sca_tests
Open

Enable Static Sca tests#680
attiasas wants to merge 9 commits intojfrog:devfrom
attiasas:enable_static_sca_tests

Conversation

@attiasas
Copy link
Collaborator

@attiasas attiasas commented Feb 23, 2026

Enable static SCA tests and fix test error handling

Summary

Re-enable static SCA integration tests that were previously globally skipped due to remediation API unavailability (now resolved). Update testAuditCommandNewSca to return errors alongside output, allowing proper validation of fail-build behavior in violation tests. Add targeted skip guards for two known Xray bugs (XRAY-135832, XRAY-136444) instead of blanket-skipping all new SCA tests.

Changes

  • audit_test.go: Changed testAuditCommandNewSca to return (string, error) (via RunCliCmdWithOutputs), updated all callers to handle the error. TestAuditNewScaSimpleJsonViolations now asserts the expected ExitCodeVulnerableBuild CLI error. Added skip guard on TestAuditNewScaCycloneDxNpm for XRAY-135832. Updated Gradle expected counts (10→11 vulns, 6→7 components) and npm SBOM component breakdown (direct/transitive split).
  • git_test.go: Added skip guard on TestGitAuditStaticScaCycloneDx for XRAY-136444. Removed unnecessary WithSbom param from the git static SCA test.
  • go.mod: Promoted golang.org/x/sys from indirect to direct dependency.
  • tests/utils/integration/test_integrationutils.go: Removed the global skip guard from InitAuditNewScaTests since the remediation API issue is resolved.

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@attiasas attiasas added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Feb 23, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 23, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 23, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 23, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 24, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 24, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 2, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 2, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 2, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 2, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 2, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 2, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 2, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 2, 2026
@attiasas attiasas requested a review from a team March 2, 2026 12:02
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 2, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 2, 2026
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

👍 Frogbot scanned this pull request and did not find any new security issues.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants