Added logic for updating HF_ENDPOINT and HF_TOKEN from default or spe…#3379
Merged
naveenku-jfrog merged 10 commits intojfrog:masterfrom Mar 5, 2026
Conversation
…cific server details itself
naveenku-jfrog
added
the
safe to test
naveenku-jfrog
added
safe to test
naveenku-jfrog
added
safe to test
naveenku-jfrog
added
safe to test
# Conflicts: # go.mod
…cific server details itself # Conflicts: # go.mod # go.sum
naveenku-jfrog
added
safe to test
naveenku-jfrog
added
safe to test
naveenku-jfrog
added
safe to test
Contributor
agrasth
reviewed
Mar 5, 2026
| return cliutils.PrintHelpAndReturnError("Please specify a repository key.", c) | ||
| } | ||
| hfEndpoint := serverDetails.GetArtifactoryUrl() + huggingfaceAPI + "/" + repoKey | ||
| err := os.Setenv(HF_ENDPOINT, hfEndpoint) |
Contributor
There was a problem hiding this comment.
We can add some logs stating "Setting HF_ENDPOINT to:", hfEndpoint , WDYT?
Collaborator
Author
There was a problem hiding this comment.
Actually we should not expose HF_ENDPOINT and HF_TOKEN in logs.
agrasth
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....What: Added logic for updating HF_ENDPOINT and HF_TOKEN from default or specific server details itself
Why: Taking advantage of already stored config instead of manually exporting token and endpoint.
Testing: Done, on artifactory instance.