Add option to control AM version, fix CA result parsing#522
Merged
attiasas merged 8 commits intojfrog:masterfrom Mar 1, 2026
Merged
Add option to control AM version, fix CA result parsing#522attiasas merged 8 commits intojfrog:masterfrom
attiasas merged 8 commits intojfrog:masterfrom
Conversation
meirjfrog
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurable Analyzer Manager version and improved CA result parsing
Summary
Add a user-configurable scanner binary (Analyzer Manager) version override in the plugin's Advanced settings, update the default AM version to 1.30.1, and rework Contextual Analysis SARIF output parsing to use a rules-based approach that reads applicability status from rule properties instead of relying on result kind/suppression alone. Informational SARIF results are now filtered out across all scanners.
Changes
scannerBinaryVersionfield toServerConfigImpl(with builder, equals, hashCode),GlobalSettings, and the Advanced tab UI (JFrogGlobalConfiguration.form/.java). The download logic inScanBinaryExecutorresolves the effective version (user override or default1.30.1) and re-downloads when the configured version changes.ApplicabilityScannerExecutornow overridesparseOutputSarifto determine applicability fromrule.properties.applicability(applicable/not_applicable), deduplicates rules (preferring applicable over not_applicable), and createsnotApplicablewarnings via a new factory method onJFrogSecurityWarning.ScanBinaryExecutor.parseOutputSarifand the new CA parser skip results wherekind == "informational".PyPipEnvPackageManagerwithPyPackageManager.ServerConfigImpl.equalsnow usesObjects.equalsforexternalResourcesRepo(was==).namefield toRule, removed unusedartifactoryPublishblocks from test Gradle files, updated tests for the new parsing logic.Testing
Updated
ScanBinaryExecutorTest.testSarifParserApplicResultsWithRulesBasedParsingto verify the new rules-based CA parsing (2 results: 1 not-applicable, 1 applicable).Added
testSarifParserSkipsInformationalResultswith a newsecrets_with_informational_output.sariffixture.Updated Gradle test fixtures and assertions for compatibility.
All tests passed. If this feature is not already covered by the tests, I added new tests.