Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new local CLI (linkctl) to control an Insta360 Link camera by talking to linkctl-daemon over a new TCP control socket, enabling camera control without requiring the existing WebSocket client/hardware UI flow.
Changes:
- Introduces
host/linkctlCLI client (POSIX C) with one-shot commands and an interactive jog mode. - Adds a TCP control socket to
linkctl-daemon(port 9001) and a background service loop to process CLI commands. - Updates WebSocket command handling to emit an
"ack"response for non-statuscommands; updates.gitignorefor CMake build dirs.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| host/linkctl/README.md | Documents building/using the new linkctl CLI and jog mode. |
| host/linkctl/linkctl.c | Implements TCP client commands + interactive jog mode. |
| host/linkctl/CMakeLists.txt | Adds CMake build/install for linkctl. |
| host/linkctl-daemon/control.h | Declares the new TCP control socket interface and default port. |
| host/linkctl-daemon/control.c | Implements line-based TCP control protocol and camera command dispatch. |
| host/linkctl-daemon/main.c | Starts the TCP control service loop in a new pthread; integrates init/shutdown. |
| host/linkctl-daemon/server.c | Adds WebSocket "ack" messages for successful non-status commands. |
| host/linkctl-daemon/CMakeLists.txt | Adds control.c to daemon build. |
| .gitignore | Ignores host/*/build/ directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System now supports daemon interaction via CLI!!! No hardware required anymore.