Skip to content

Pin GitHub Actions to commit SHAs - #411

Merged
jgassens merged 1 commit into
mainfrom
ci/pin-actions
Nov 18, 2026
Merged

jgassens merged 1 commit into
mainfrom
ci/pin-actions

Conversation

@jgassens

Copy link
Copy Markdown
Owner

Pins every third-party GitHub Action in four workflows to a full commit SHA, with the exact release tag as a trailing comment (@<sha> # vX.Y.Z). A version tag like @v4 can be moved to different code by the action's owner; a commit SHA cannot.

Workflows (36 pins)

Workflow Lines pinned
.github/workflows/ci.yml 16
.github/workflows/windows-release.yml 11
.github/workflows/macos-intel-smoke.yml 5
.github/workflows/pages.yml 4

Pins

Action Was Now Uses
actions/checkout @v4 11d5960a326750d5838078e36cf38b85af677262 # v4.4.0 9
actions/setup-node @v4 49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 7
pnpm/action-setup @v4 b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0 6
Swatinem/rust-cache @v2 d1527c8f67ef9af357290475d4af4b0fab8f12e0 # v2.9.3 5
actions/setup-java @v4 cf277c60eb25467037889841efdb72551f06f6c3 # v4.9.1 2
actions/upload-artifact @v4 ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 2
actions/download-artifact @v4 d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 1
actions/configure-pages @v5 983d7736d9b0ae728b81ab479565c72886d7745b # v5.0.0 1
actions/upload-pages-artifact @v3 56afc609e74202658d3ffba0e8f6dda462b719fa # v3.0.1 1
actions/deploy-pages @v4 d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4.0.5 1
signpath/github-action-submit-signing-request already pinned, # v2 same SHA, comment # v2.3 1

How each SHA was checked

  • For each action, the commit that the previously used major tag (v4, v2, ...) points at today was read from GitHub, so CI keeps running the same code it runs now.
  • The exact release tag at that commit (v4.4.0, ...) was looked up, and that tag was resolved again on its own to confirm it points at the same commit.
  • An independent review compared every changed line against that table and byte-compared the rest of each file with its parent: only the uses: lines changed, and all four files still parse as YAML.

The Linux workflows (linux-release.yml, linux-container-smoke.yml) are pinned separately in #410; their checkout pin is moving to the same v4.4.0 SHA used here.

Edited by openai-luna (run-20261117-201611-c3f634).

Reviewed-by: openai-astra run-20261117-201611-c3f634

🤖 Generated with Claude Code

ci.yml, windows-release.yml, macos-intel-smoke.yml and pages.yml now pin
every third-party action to a full commit SHA with the exact release tag
as a trailing comment ("@<sha> # vX.Y.Z"). Each SHA is the commit the
previously used major tag points at today, so CI runs the same code; the
session checked that the major tag and the exact release tag both resolve
to it. The SignPath pin keeps its SHA; its comment now names v2.3. The
Linux workflows are pinned separately on ci/linux-release-hardening.

Edited by openai-luna (run-20261117-201611-c3f634, task pinall).

Reviewed-by: openai-astra run-20261117-201611-c3f634

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jgassens
jgassens marked this pull request as ready for review November 18, 2026 02:46
@jgassens
jgassens merged commit 297dea2 into main Nov 18, 2026
8 checks passed
@jgassens
jgassens deleted the ci/pin-actions branch November 18, 2026 02:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T02:47:07.280596Z 33962d7 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-18T02:48:17.418020Z 33962d7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant