Skip to content

fix(api): skip only canonically encoded request paths - #82

Open
josuegiron wants to merge 1 commit into
masterfrom
fix/skip-path-escaped-match
Open

josuegiron wants to merge 1 commit into
masterfrom
fix/skip-path-escaped-match

Conversation

@josuegiron

Copy link
Copy Markdown
Member

ProcessRequest now matches SkipPaths only when the request path is sent as Go's canonical encoding of its decoded path (empty URL.RawPath). A path with an escaped slash (%2F, %2f), another non-canonical escape, or a raw ! ' ( ) * is processed instead of skipped, since a router that matches the escaped path may route it to a different handler.

  • skipsRequest helper in middlewares.go; docs on SkipPaths/GenSkipPath, README and ADR 0002 item 6.
  • Table test covering normal, query, canonically escaped, %2F, %2f, %252F, escaped letter and sub-delim paths.

Release: PATCH (v1.1.2). Restores the documented intent of skip paths; skip paths spelled with raw sub-delims now get processing (fail-safe).

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant