Repository navigation
fix(async): quote the key in the get not-found error - #12
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container.Getreturnedcontainer: item not found, key (%v)with the key written verbatim. Keys may come from untrusted input (the package documentsTrySetfor that case), so a key with line breaks or other control characters ended up raw in error text that callers log.The key is now rendered with
fmt.Sprintand quoted with%q:key ("a\nb"),key ("65")(quoting the string form avoids rune literals for integer keys). The nil-map branch was folded into the single not-found branch, since a lookup in a nil map already reports a missing key.TestContainerGetMissingKeyQuotesKey(newline, CR/ESC and integer keys; fails before the change).gofmt -l .empty,go vet ./...,go test -race ./...,govulncheck ./...clean.Behavior note for release notes: the error text changes (the key is quoted).
🤖 Generated with Claude Code