Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions error_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -285,3 +285,18 @@ func TestNonCodedErrorAttributeStaysString(t *testing.T) {
})
}
}

func TestCodedErrorAttributeOfStacklessSentinelHasEmptyDebug(t *testing.T) {
var buf bytes.Buffer
instance := New(WithJSONHandler(&buf))

instance.Error("failed", "error", errLogTitleRequired)

group, ok := decodeRecord(t, &buf)["error"].(map[string]any)
if !ok {
t.Fatalf("expected an error group, got %q", buf.String())
}
if debug, has := group["debug"]; !has || debug != "" {
t.Fatalf("expected an empty debug attribute, got %v", group)
}
}
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ module github.com/jgolang/log

go 1.26.2

require github.com/jgolang/errors v0.6.2
require github.com/jgolang/errors v0.7.0

require github.com/go-errors/errors v1.5.1 // indirect
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
github.com/go-errors/errors v1.5.1 h1:ZwEMSLRCapFLflTpT7NKaAc7ukJ8ZPEjzlxt8rPN8bk=
github.com/go-errors/errors v1.5.1/go.mod h1:sIVyrIiJhuEF+Pj9Ebtd6P/rEYROXFi3BopGUQ5a5Og=
github.com/jgolang/errors v0.6.2 h1:862DCmlZowra5H198sQgqInMLBTsC5Ani51J37k4XMM=
github.com/jgolang/errors v0.6.2/go.mod h1:7jzxJ5Ox468U7Jk0R+JWI3sfPfLGSwPOie7ISDYlVhY=
github.com/jgolang/errors v0.7.0 h1:vOxGpGXUkevRLkGHRyJmPmlsWUN9GY5/kc9vw3krEzM=
github.com/jgolang/errors v0.7.0/go.mod h1:7jzxJ5Ox468U7Jk0R+JWI3sfPfLGSwPOie7ISDYlVhY=
6 changes: 1 addition & 5 deletions internal/codederror/codederror.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,7 @@ func GroupWithText(key string, err error, coded *errors.Error) slog.Attr {
}

func fields(coded *errors.Error) []slog.Attr {
debug := ""
if coded.Wrapper != nil {
debug = coded.Wrapper.Error()
}

debug := coded.Detail()
origin := slog.Attr{Key: "origin", Value: coded.StackTrace()}
code := errors.CodeOf(coded)
if code == nil {
Expand Down
Loading