Repository navigation
ci: test otel against the log in the same commit - #55
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a last CI step,
test (otel against this commit's log): inotel/it runsgo mod edit -replace github.com/jgolang/log=../,go mod tidyandgo test -race ./.... The replace lives only in the CI checkout and is never committed.Why
CI tested
otelonly against the published log inotel/go.mod(today v1.7.1), so a root change that breaksotelsurfaced only when the next otel release raised its requirement (epic-licenses-process-hygiene retrospective finding 5). The existing otel steps still run first against the published graph, which is what users get, so nothing is lost.Tests
CI-only change. Tried locally on master: replace + tidy +
go test -race ./...inotel/passes; the working tree was restored afterwards.🤖 Generated with Claude Code