Repository navigation
fix: do not panic when logging typed-nil wrapper errors - #61
Open
josuegiron wants to merge 1 commit into
Open
josuegiron wants to merge 1 commit into
josuegiron wants to merge 1 commit into
Conversation
The coded-error walk called Unwrap on a nil pointer and the message path called Error on it; both panic for types that dereference the receiver. Stop the walk at nil pointers and write panicking Error results as slog does (<nil> or !PANIC). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Logging a typed-nil error whose
UnwraporErrordereferences its receiver panicked in the coded-error walk (internal/codederror) or when it was the message argument. Plain slog writes<nil>for such a value.Unwrap.codederror.TextcallsError()and writes a panic as slog does:<nil>for a nil pointer,!PANIC: <value>otherwise. Used for the message and the group'stext.Verification
gofmt -l .,go vet ./...,go test -race ./...,govulncheck ./.... Tests cover the typed nil as an attribute, in a group, behindfmt.Errorfanderrors.Join, joined with a coded error, and as the package-level message.BenchmarkValidateArgs: same bytes and allocations before and after.🤖 Generated with Claude Code