fix: prevent server-side Svelte code in client bundle - #11
Merged
Merged
Conversation
The resolve.conditions config added for Vitest support set conditions to [] for production builds, which removed the 'browser' condition in Vite 7. This caused Svelte's server-side onDestroy (ssr_context.r.on_destroy) to be bundled into the client, crashing on page load with: TypeError: Cannot read properties of null (reading 'r') Fix: only set resolve.conditions when VITEST is active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
resolve.conditionsconfig added in #9 (test coverage improvements) set conditions to[]for production builds. In Vite 7, this removed thebrowserresolve condition, causing Svelte's server-sideonDestroy(ssr_context.r.on_destroy) to be bundled into the client.Result: blank page on load with:
Fix
Only set
resolve.conditionswhenVITESTis active:This keeps the
browsercondition for Vitest/jsdom while leaving Vite's default resolution untouched for production builds.