Add support for API interactions used to start and maintain a camera live stream - #28
Add support for API interactions used to start and maintain a camera live stream#28DavidValeri wants to merge 1 commit into
Conversation
|
|
||
| LOGGER.debug(result) | ||
|
|
||
| while (result["__typename"] == "WatchingStartInProgressResult"): |
There was a problem hiding this comment.
This should probably include an optional timeout on this waiting loop.
|
I initially did not go down the path of adding live streaming to the integration, because while the camera is in live streaming mode, it cannot detect bird visitors. That said, I'm less opposed to adding support for this into the pybirdbuddy library itself (more opposed in the HA integration, because it restricts the primary purpose and intention of the BB). |
Code reviewFound 2 issues:
pybirdbuddy/birdbuddy/client.py Lines 248 to 250 in e5e5031 pybirdbuddy/birdbuddy/client.py Lines 284 to 286 in e5e5031 Compare with the existing pattern: pybirdbuddy/birdbuddy/client.py Lines 320 to 323 in e5e5031
pybirdbuddy/birdbuddy/client.py Lines 257 to 262 in e5e5031 Mutation signature showing only pybirdbuddy/birdbuddy/queries/feeder.py Lines 3 to 5 in e5e5031 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Introduces the methods mapping to the API interactions for initiating a stream, checking on the stream initiation status, and maintaining the stream in an active state.
Here is a use case in action https://github.com/DavidValeri/bb-streamer. The output can be fed to an NVR or another identification system.