fix(evolution): track guide updates and refresh repository overview - #14
Closed
jhinpan wants to merge 6 commits into
Closed
fix(evolution): track guide updates and refresh repository overview#14jhinpan wants to merge 6 commits into
jhinpan wants to merge 6 commits into
Conversation
Highlight the architecture-scoped evidence pipeline and remove stale RDNA wording from the project citation. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideDocumentation-only README refresh aligning the project overview and citation with current CDNA scope, and surfacing details of the evidence/refresh pipeline and maintenance tooling. Flow diagram for the evidence refresh and validation pipelineflowchart LR
A[data_sources_yaml] --> B[daily_worker]
B --> C[disposable_clone]
C --> D[rolling_Draft_PR]
D --> E[approved_hardware_tasks]
E --> F[trusted_MI355_node_validation]
F --> G[merged_PR]
B --- H[self_evolution_boundary]
H --- I[human_review_and_merge]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider briefly defining terms like “budgeted refresh pipeline” and “review-gated evidence flywheel” or linking to sections that explain them, so readers unfamiliar with your internal nomenclature can understand the workflow quickly.
- The sentence describing the daily worker and trusted MI355 node is dense; breaking it into two sentences or a short bullet list could make the maintenance pipeline and hardware validation steps clearer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider briefly defining terms like “budgeted refresh pipeline” and “review-gated evidence flywheel” or linking to sections that explain them, so readers unfamiliar with your internal nomenclature can understand the workflow quickly.
- The sentence describing the daily worker and trusted MI355 node is dense; breaking it into two sentences or a short bullet list could make the maintenance pipeline and hardware validation steps clearer.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Distinguish independent freshness boundaries and document the canonical scope, source registry, and evaluation scripts. Co-authored-by: Cursor <cursoragent@cursor.com>
Explain how complete baseline harvests relate to incremental source cursors, and clarify refresh pipeline budgets for reviewers. Co-authored-by: Cursor <cursoragent@cursor.com>
Describe maintainer-controlled Draft PRs and disclose the administrator bypass instead of overstating technical enforcement. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep future guide updates inside the allowlist and align freshness, Draft PR, budget, and CI documentation with the enforced behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Persist conservative initial cursors after successful empty scans so rolling refreshes remain resumable, and align governance wording with maintainer-controlled behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Superseded by #15, which preserves the same reviewed tree plus the final watermark fixes in one exact-author commit. The replacement avoids force-pushing this review history and allows a rebase merge that retains Jin Pan jin.pan@amd.com. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
python3 -m pytest tests(56 passed)python3 scripts/validate.py(0 errors)