Skip to content

test(mi355): verify evidence worker deployment - #16

Closed
jhinpan wants to merge 2 commits into
mainfrom
test/mi355-evidence-e2e-20260724
Closed

test(mi355): verify evidence worker deployment#16
jhinpan wants to merge 2 commits into
mainfrom
test/mi355-evidence-e2e-20260724

Conversation

@jhinpan

@jhinpan jhinpan commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • exercise the deployed MI355 exact-SHA approval gate
  • verify a subsequent push invalidates the prior approval
  • produce and validate an immutable mi355-evidence bundle

Test plan

  • approve the initial exact SHA and confirm dry-run admission
  • push a new SHA and confirm the old approval is rejected
  • approve the new SHA and run the hardware evidence worker
  • verify the check URL and content-addressed evidence digest

This deployment-only PR will be closed without merging after verification.

Made with Cursor

Summary by Sourcery

Documentation:

  • Record the MI355 evidence worker e2e validation steps in a dedicated text file under the validation directory.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@sourcery-ai

sourcery-ai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Deployment-only PR adding an MI355 hardware evidence worker end-to-end validation script to exercise the exact-SHA approval gate and evidence bundle verification flow.

File-Level Changes

Change Details Files
Add an end-to-end validation script/spec for the MI355 hardware evidence worker deployment and approval flow.
  • Introduce a text-based e2e scenario file documenting steps to approve an exact SHA and validate dry-run admission.
  • Document behavior when a new SHA is pushed and previous approvals are invalidated.
  • Describe running the hardware evidence worker, checking the result URL, and validating the content-addressed evidence digest.
  • Clarify that the workflow is deployment-only and the PR is intended to be closed after manual verification.
validation/mi355-worker-e2e.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@jhinpan jhinpan added the mi355-approved Exact-SHA maintainer-approved MI355 hardware evidence label Jul 24, 2026
@jhinpan

jhinpan commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

/mi355-approve 6d44e79

Co-authored-by: Cursor <cursoragent@cursor.com>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jhinpan

jhinpan commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

/mi355-approve 607d356

@jhinpan

jhinpan commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

MI355 deployment E2E passed.

  • Initial exact-SHA approval admitted: 6d44e7996212598398af18784b31fc7fbce5aa6b
  • New push invalidated that approval: 607d35690eadc103c6bc93c6eb9b33265ecc7092
  • New exact-SHA approval produced 26 pass / 0 fail / 1 source-recorded
  • Check: https://github.com/jhinpan/ROCmKernelWiki/runs/89410734615
  • Evidence SHA-256: 6a413681c8594cfffca91e2570f69760a269fe0552dd784cda3a0c63426f7322

Closing without merge; this PR was deployment-only.

@jhinpan jhinpan removed the mi355-approved Exact-SHA maintainer-approved MI355 hardware evidence label Jul 24, 2026
@jhinpan jhinpan closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant