fix: SentryHandler not handle stack trace#225
Open
shenjingfs wants to merge 2 commits intojhomlala:masterfrom
Open
fix: SentryHandler not handle stack trace#225shenjingfs wants to merge 2 commits intojhomlala:masterfrom
shenjingfs wants to merge 2 commits intojhomlala:masterfrom
Conversation
|
Can this be merged? @jhomlala |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #213 #191
As of Sentry 4.0.0, the type of the
SentryEvent.stackTracehas been changed fromdynamictoSentryStackTrace, and a new parameterdynamic stackTracehas been added toSentryClient.captureEvent.The commit #724a4d removes
stackTracein thebuildEventmethod, but callsSentryClient.captureEventwithout addingstackTrace, which causes Sentry to captureStackTrace.current