Repository navigation
Keep castbar border fit consistent across all artwork - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Castbar borders previously used identical canvas bounds despite different transparent insets. Changing target class could therefore leave a visibly wider or taller opening with the same fitting settings.
Register all 42 designs by their measured painted rails, preserving every original image and decorative detail. Width, height, weight and padding now describe a consistent opening. Refresh only owned texture regions when identity changes, including in combat; native bars and root anchors stay untouched. Apply the same registration to the shared Party and Target of Target borders. Includes regenerated previews and 0.9.11 packages.
Validation: 412 Lua checks, 38 Python checks, source/provenance validation and both exact client archives pass. New checks project solid artwork pixels through runtime geometry for every design and preview size, exercise combat class swaps on all three providers and both clients, and preserve full source coverage and uniform corner scale. Visually reviewed the castbar preview. All 298 runtime images are unchanged. Live WoW validation remains pending.