Repository navigation
Add per-member party diagnostics without pasted scripts - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Party borders can report three attached frames but only one visible member, and a pasted diagnostic script may fail before printing anything. Add
/jf partydebug(also/jf status party) to report each cached member's unit assignment, attachment, artwork state, and native visibility/opacity reads independently.The command labels secret, unavailable and failed reads without printing their contents, continues past individual failures, and runs only when requested. Version 0.9.13 makes no rendering, artwork or settings changes; the remaining EllesmereUI border issue still requires the player's diagnostic output.
Validation: 427 offline Lua tests passed, including all three party providers on both client variants, protected values, throwing getters, missing units, and read-only behavior in combat. Python suite passed (26 tests; 4 optional source-art audits skipped). Cast preview matches; all 298 runtime artwork hashes and both 334-file client archives verified. No game access or in-game testing.