fix: increase tickDenominator to 60480 for correct tuplet resolution#129
Open
KelvinCreighton wants to merge 1 commit into
Open
fix: increase tickDenominator to 60480 for correct tuplet resolution#129KelvinCreighton wants to merge 1 commit into
KelvinCreighton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The previous tickDenominator of 1024 (2^10) only guaranteed clean division
for regular notes. Tuplets such as triplets, quintuplets, and septuplets
produce RealValue denominators that don't divide evenly into 1024, causing
floating point tick positions and scheduling drift most noticeably with
16th note triplets and other edge cases.
Fix
Changed tickDenominator from 1024 to 60480.
60480 = 2^6 × 3^3 × 5 × 7
This ensures all common tuplet RealValues divide evenly into the tick
grid, eliminating rounding errors in tick position calculation.
Trade-off
2^6 vs the previous 2^10 means lower binary resolution, but 64th note
precision is more than sufficient for any practical score.