feat: Implement HTTP/1.1 request parser with pipeline integration#70
Merged
Conversation
- Add request.gleam with HttpVersion and ParsedRequest types - Add url.gleam with percent-encoding/decoding (RFC 3986) - Add parser.gleam for request line, headers, and body parsing - Add builder.gleam for HTTP request serialization - Add stage.gleam with decode/encode stages and Protocol registration - Support Content-Length and Chunked Transfer-Encoding body parsing - Support HTTP pipelining with remaining_bytes return - Integrate with gleam_http library types (Method, Request) - Add comprehensive unit tests for all modules (677 tests passing)
|
Caution Review failedThe pull request is closed. Walkthrough이 PR은 Gleam으로 구현한 완전한 HTTP/1.1 요청 처리 시스템을 도입합니다. 요청 데이터 타입 정의, 파싱 로직, 직렬화 로직, 프로토콜 스테이지 통합, URL 인코딩/디코딩을 포함하며, 광범위한 테스트 스위트로 검증됩니다. Changes
Sequence DiagramsequenceDiagram
participant Raw as Raw HTTP Bytes
participant Parser as HTTP Parser
participant PR as ParsedRequest
participant Stage as HTTP Stage
participant Meta as Metadata
participant Builder as HTTP Builder
participant Out as Output Bytes
Raw->>Parser: parse_request(bytes)
Parser->>Parser: parse_request_line()
Parser->>Parser: parse_headers()<br/>(lowercase keys)
Parser->>Parser: parse_body()<br/>(Content-Length or Chunked)
Parser->>PR: construct ParsedRequest
PR->>Stage: decode() stage
Stage->>Stage: convert to gleam_http Request
Stage->>Meta: store HttpRequestData<br/>(request + remaining_bytes)
Meta->>Stage: get request for encoding
Stage->>Builder: encode() stage
Builder->>Builder: build_request_line()
Builder->>Builder: build_headers()
Builder->>Builder: handle Content-Length/<br/>Transfer-Encoding
Builder->>Out: build complete HTTP bytes
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 분 특별히 검토가 필요한 영역:
Poem
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Free 📒 Files selected for processing (10)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/pull_request_template.md
🎯 변경 사항
📋 체크리스트
gleam format실행 완료gleam check통과🧪 테스트 방법
🤖 CodeRabbit 리뷰 요청사항
📸 스크린샷/데모
참고: 댓글에
@coderabbitai 다시 리뷰해줘라고 작성하면 전체 재리뷰를 요청할 수 있습니다.Summary by CodeRabbit
릴리스 노트
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.