Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new CLI command to update stake history for a specific vote account. The implementation introduces an "UpdateStakeHistory" action that calculates stake rank and superminority status for a given validator and submits an on-chain transaction to update the validator history.
- Adds new CLI command
UpdateStakeHistoryto update stake history for a single vote account - Exposes
get_stake_rank_map_and_superminority_countfunction as public API - Creates new
actionsmodule to organize action-based commands separately from cranks
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/validator-history-cli/src/main.rs | Imports and registers the new UpdateStakeHistory CLI command |
| utils/validator-history-cli/src/commands/mod.rs | Adds public module declaration for actions |
| utils/validator-history-cli/src/commands/actions/mod.rs | Module declaration for update_stake_history |
| utils/validator-history-cli/src/commands/actions/update_stake_history.rs | Implements the core logic to update stake history for a specific vote account |
| keepers/stakenet-keeper/src/operations/stake_upload.rs | Changes function visibility from private to public to enable reuse |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
utils/validator-history-cli/src/commands/actions/update_stake_history.rs
Outdated
Show resolved
Hide resolved
utils/validator-history-cli/src/commands/actions/update_stake_history.rs
Outdated
Show resolved
Hide resolved
utils/validator-history-cli/src/commands/actions/update_stake_history.rs
Outdated
Show resolved
Hide resolved
utils/validator-history-cli/src/commands/actions/update_stake_history.rs
Outdated
Show resolved
Hide resolved
utils/validator-history-cli/src/commands/actions/update_stake_history.rs
Outdated
Show resolved
Hide resolved
utils/validator-history-cli/src/commands/actions/update_stake_history.rs
Outdated
Show resolved
Hide resolved
utils/validator-history-cli/src/commands/actions/update_stake_history.rs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.