Skip to content

feat: add diarize field to mediajson Start event #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgrozev merged 1 commit into from
Jul 14, 2026
Merged

feat: add diarize field to mediajson Start event #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jicoco-mediajson/src/main/kotlin/org/jitsi/mediajson/MediaJson.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ data class MediaFormat(
data class Start(
val tag: String,
val mediaFormat: MediaFormat,
val customParameters: CustomParameters? = null
val customParameters: CustomParameters? = null,
val diarize: Boolean? = null
)

data class CustomParameters(
Expand Down
37 changes: 37 additions & 0 deletions jicoco-mediajson/src/test/kotlin/org/jitsi/mediajson/MediaJsonTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ class MediaJsonTest : ShouldSpec() {
start.shouldBeInstanceOf<ObjectNode>()
start.get("tag").asText() shouldBe tag
start.get("customParameters") shouldBe null
// diarize is null and must be omitted from the JSON.
start.get("diarize") shouldBe null
val mediaFormat = start.get("mediaFormat")
mediaFormat.shouldBeInstanceOf<ObjectNode>()
mediaFormat.get("encoding").asText() shouldBe enc
Expand All @@ -69,6 +71,17 @@ class MediaJsonTest : ShouldSpec() {
parsedList[0] shouldBe event
parsedList[1] shouldBe event
}
context("With diarize set") {
val diarizeEvent = StartEvent(
seq,
Start(tag, MediaFormat(enc, sampleRate, channels, params), diarize = true)
)
val parsed = mapper.readTree(diarizeEvent.toJson())
parsed.shouldBeInstanceOf<ObjectNode>()
val start = parsed.get("start")
start.shouldBeInstanceOf<ObjectNode>()
start.get("diarize").asBoolean() shouldBe true
}
}
context("MediaEvent") {
val chunk = 213
Expand Down Expand Up @@ -223,6 +236,30 @@ class MediaJsonTest : ShouldSpec() {
parsed.start.mediaFormat.channels shouldBe 1
parsed.start.customParameters.shouldNotBeNull()
parsed.start.customParameters?.endpointId shouldBe "abcdabcd"
// diarize is absent from the JSON and must parse as null.
parsed.start.diarize shouldBe null
}
context("Start with diarize") {
val parsed = Event.parse(
"""
{
"event": "start",
"sequenceNumber": "0",
"start": {
"tag": "incoming",
"mediaFormat": {
"encoding": "audio/x-mulaw",
"sampleRate": 8000,
"channels": 1
},
"diarize": true
}
}
""".trimIndent()
)

parsed.shouldBeInstanceOf<StartEvent>()
parsed.start.diarize shouldBe true
}
context("Start with sequence number as int") {
val parsed = Event.parse(
Expand Down
Loading