Skip to content

Remove TracingUtil and its Smack dependency - #241

Merged
bgrozev merged 1 commit into
masterfrom
remove-tracingutil
Aug 5, 2026
Merged

Remove TracingUtil and its Smack dependency#241
bgrozev merged 1 commit into
masterfrom
remove-tracingutil

Conversation

@bgrozev

@bgrozev bgrozev commented Aug 5, 2026

Copy link
Copy Markdown
Member

TracingUtil bridged an XMPP <traceparent> stanza extension into an OpenTelemetry span/context. It depended directly on jitsi-xmpp-extensions and (transitively) the jitsi-patched smack-core fork, neither of which are available on Maven Central.

jicoco-tracing is listed under the central-modules profile, which the release-to-Central job builds without the non-central repositories enabled — so the release failed trying to resolve smack-core:4.4.8-jitsi-4:

https://github.com/jitsi/jicoco/actions/runs/30963018171/job/92171674688

This removes TracingUtil and the now-unused dependencies. Callers should inline the IQ-to-span-context logic themselves.

…dependency

TracingUtil bridged an XMPP <traceparent> stanza extension into an
OpenTelemetry span/context, which required a direct dependency on
jitsi-xmpp-extensions and (transitively) the jitsi-patched smack-core fork.
Both are unavailable on Maven Central, but jicoco-tracing is a central-modules
module (see root pom.xml) -- the release-to-Central job doesn't enable the
non-central repos, so it failed to resolve smack-core:4.4.8-jitsi-4:

https://github.com/jitsi/jicoco/actions/runs/30963018171/job/92171674688

Callers should inline the IQ-to-span-context logic themselves rather than
depend on jicoco-tracing for it.
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.54%. Comparing base (d754d3d) to head (92e5aaa).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
- Coverage     35.99%   35.54%   -0.45%     
+ Complexity      167      163       -4     
============================================
  Files            39       38       -1     
  Lines          1439     1429      -10     
  Branches        144      143       -1     
============================================
- Hits            518      508      -10     
  Misses          888      888              
  Partials         33       33              

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d754d3d...92e5aaa. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bgrozev added a commit to JulianGCalderon/jitsi-videobridge that referenced this pull request Aug 5, 2026
jicoco-tracing removed TracingUtil (and its Smack/jitsi-xmpp-extensions
dependency, which isn't available on Maven Central):
jitsi/jicoco#241

Inline the two functions locally instead of depending on jicoco-tracing for them.
bgrozev added a commit to JulianGCalderon/jitsi-jicofo that referenced this pull request Aug 5, 2026
jicoco-tracing removed TracingUtil (and its Smack/jitsi-xmpp-extensions
dependency, which isn't available on Maven Central):
jitsi/jicoco#241

Inline the two functions locally instead of depending on jicoco-tracing for them.
jitsi-ci Bot pushed a commit to jitsi/jitsi-pr-tests-pages that referenced this pull request Aug 5, 2026
@damencho

damencho commented Aug 5, 2026

Copy link
Copy Markdown
Member

jenkins test this please

jitsi-ci Bot pushed a commit to jitsi/jitsi-pr-tests-pages that referenced this pull request Aug 5, 2026
@bgrozev
bgrozev merged commit a09ed33 into master Aug 5, 2026
6 of 7 checks passed
@bgrozev
bgrozev deleted the remove-tracingutil branch August 5, 2026 15:05
bgrozev added a commit to JulianGCalderon/jitsi-videobridge that referenced this pull request Aug 5, 2026
Picks up jitsi/jicoco#241 (TracingUtil removal), which this branch now inlines
locally instead of depending on.
bgrozev added a commit to JulianGCalderon/jitsi-jicofo that referenced this pull request Aug 5, 2026
Picks up jitsi/jicoco#241 (TracingUtil removal), which this branch now inlines
locally instead of depending on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants