Remove TracingUtil and its Smack dependency - #241
Merged
Conversation
…dependency TracingUtil bridged an XMPP <traceparent> stanza extension into an OpenTelemetry span/context, which required a direct dependency on jitsi-xmpp-extensions and (transitively) the jitsi-patched smack-core fork. Both are unavailable on Maven Central, but jicoco-tracing is a central-modules module (see root pom.xml) -- the release-to-Central job doesn't enable the non-central repos, so it failed to resolve smack-core:4.4.8-jitsi-4: https://github.com/jitsi/jicoco/actions/runs/30963018171/job/92171674688 Callers should inline the IQ-to-span-context logic themselves rather than depend on jicoco-tracing for it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
============================================
- Coverage 35.99% 35.54% -0.45%
+ Complexity 167 163 -4
============================================
Files 39 38 -1
Lines 1439 1429 -10
Branches 144 143 -1
============================================
- Hits 518 508 -10
Misses 888 888
Partials 33 33 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
bgrozev
added a commit
to JulianGCalderon/jitsi-videobridge
that referenced
this pull request
Aug 5, 2026
jicoco-tracing removed TracingUtil (and its Smack/jitsi-xmpp-extensions dependency, which isn't available on Maven Central): jitsi/jicoco#241 Inline the two functions locally instead of depending on jicoco-tracing for them.
bgrozev
added a commit
to JulianGCalderon/jitsi-jicofo
that referenced
this pull request
Aug 5, 2026
jicoco-tracing removed TracingUtil (and its Smack/jitsi-xmpp-extensions dependency, which isn't available on Maven Central): jitsi/jicoco#241 Inline the two functions locally instead of depending on jicoco-tracing for them.
jitsi-ci Bot
pushed a commit
to jitsi/jitsi-pr-tests-pages
that referenced
this pull request
Aug 5, 2026
Member
|
jenkins test this please |
jitsi-ci Bot
pushed a commit
to jitsi/jitsi-pr-tests-pages
that referenced
this pull request
Aug 5, 2026
damencho
approved these changes
Aug 5, 2026
JonathanLennox
approved these changes
Aug 5, 2026
hristoterezov
approved these changes
Aug 5, 2026
bgrozev
added a commit
to JulianGCalderon/jitsi-videobridge
that referenced
this pull request
Aug 5, 2026
Picks up jitsi/jicoco#241 (TracingUtil removal), which this branch now inlines locally instead of depending on.
bgrozev
added a commit
to JulianGCalderon/jitsi-jicofo
that referenced
this pull request
Aug 5, 2026
Picks up jitsi/jicoco#241 (TracingUtil removal), which this branch now inlines locally instead of depending on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TracingUtil bridged an XMPP
<traceparent>stanza extension into an OpenTelemetry span/context. It depended directly onjitsi-xmpp-extensionsand (transitively) the jitsi-patchedsmack-corefork, neither of which are available on Maven Central.jicoco-tracingis listed under thecentral-modulesprofile, which the release-to-Central job builds without the non-central repositories enabled — so the release failed trying to resolvesmack-core:4.4.8-jitsi-4:https://github.com/jitsi/jicoco/actions/runs/30963018171/job/92171674688
This removes
TracingUtiland the now-unused dependencies. Callers should inline the IQ-to-span-context logic themselves.