feat: Send server info message on transcriber connection - #101
Conversation
Code Review — PR #101: feat: Send server info message on transcriber connectionGood feature overall — clean motivation, readable implementation, and appropriate documentation updates. A few items worth addressing: Potential Bug: Worker Augmentation Only in Dispatcher PathThe Suggestion: Verify that Minor: Fallback Inconsistency Between Build and DevIn Suggestion: Consider a single canonical fallback (e.g. Low-Risk: Log Injection via Client-Sent
|
| Area | Assessment |
|---|---|
| Code correctness | ✅ Good — safe fallbacks, readyState check, try/catch |
| Conventions | ✅ CLAUDE.md updated per project requirement |
| Security | info payload) |
| Test coverage | transcriberproxy.ts changes untested |
| Potential bug | ❓ Worker augmentation scope (dispatcher-only path?) |
The feature is well-structured and the build-time git hash injection is a clean approach. Resolving the dispatcher-path question is the most important item before merging.
Adds an
infoWebSocket message sent once per connection (and on reattach) carrying the running build, the effective provider, high-level session config, and deployment/runtime details. Motivation: runtime observability of what is actually deployed, independent of the deployment pipeline.gitHashis baked into the bundle at build time via esbuilddefine(build.mjs→src/buildInfo.ts), so it is present for bothdocker:buildand the Cloudflare/wrangler image build.workerblock: deployed worker version (via the newversion_metadata/CF_VERSION_METADATAbinding), edge colo/location (request.cf), and routing mode.runtime(node vs cloudflare-container), instance id and location when available.infomessage the client (JVB) sends.Companion changes (JVB side + shared schema): jitsi/jitsi-videobridge#2423, jitsi/jicoco#236.