cli: switch from atty crate to crossterm#783
Conversation
|
This still fails the cargo-deny check because we also depend on atty via clap. There's clap-rs/clap#4249 for that. I'll see how to disable this check for now.\ |
martinvonz
force-pushed
the
push-0b5afee10ab147d099ad3b4c2729b457
branch
from
84aa1a4 to
ba8e3f3
Compare
|
We can also use crossterm for free. |
Oh, that's even better. I'll make that change. |
The `atty` crate seems unmaintained. There's https://rustsec.org/advisories/RUSTSEC-2021-0145 filed against it, which `cargo-deny` complains about. A fix for that has been open for well over a year without being fixed (softprops/atty#51). It turns out the functionality is also available via the `crossterm` crate (thanks, @yuja), which we already depend on. Since we also depend on `atty` via `clap`, I also added an exception to the `cargo-deny` config.
martinvonz
force-pushed
the
push-0b5afee10ab147d099ad3b4c2729b457
branch
from
ba8e3f3 to
bb3d480
Compare
Done. |
martinvonz
changed the title
atty crate to is-terminalatty crate to crossterm
|
Clap has now been migrated off of |
3 participants
The
attycrate seems unmaintained. There'shttps://rustsec.org/advisories/RUSTSEC-2021-0145 filed against it, which
cargo-denycomplains about. A fix for that has been open for well over a year without being fixed(softprops/atty#51). The
is-terminalcrate is a fork ofattywith that fixed, plus some other changes.Checklist
If applicable:
CHANGELOG.md