Skip to content

pr template: ask contributors to review and copy-edit AI contributions#8897

Merged
ilyagr merged 1 commit into
mainfrom
ig/ai-pr-rules
Mar 3, 2026
Merged

pr template: ask contributors to review and copy-edit AI contributions#8897
ilyagr merged 1 commit into
mainfrom
ig/ai-pr-rules

Conversation

@ilyagr
Copy link
Copy Markdown
Contributor

@ilyagr ilyagr commented Feb 17, 2026

The goal is to nudge contributors towards taking on the burden of understanding and editing any AI-generated work they are trying to get reviewed.

AFAICT, jj is currently less overwhelmed with low-quality AI contributions than to some other projects, but it started to happen occasionally.

For now, this is partly an experiment as opposed to a fixed rule. Will the people who most need this guidance read it and benefit from it? Hopefully, they'll try to or will ask questions.

I considered also adding a clarification to the second point, suggesting something like "If in doubt, delete all the AI-generated text and rewrite it in your own words", but that point was already getting long. We could add something like that later.

Update: See See #8897 (comment)
below for some reasons I didn't want to require disclosing whether people
used AI tools while preparing the PR.

Checklist

If applicable:

  • [n/a] I have updated CHANGELOG.md
  • [n/a] I have updated the documentation (README.md, docs/, demos/)
  • [n/a] I have updated the config schema (cli/src/config-schema.json)
  • [n/a] I have added/updated tests to cover my changes

@ilyagr ilyagr marked this pull request as ready for review February 17, 2026 04:18
@ilyagr ilyagr requested a review from a team as a code owner February 17, 2026 04:18
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@PhilipMetzger
Copy link
Copy Markdown
Contributor

While I in general like the idea, I don't consider it a good execution. In my opinion if we want to pursue something like this we should orient ourselves on https://docs.fedoraproject.org/en-US/council/policy/ai-contribution-policy/ and https://discourse.llvm.org/t/rfc-llvm-ai-tool-policy-human-in-the-loop/89159 which resulted in llvm/llvm-project#154441.

Copy link
Copy Markdown
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds good to me so I'm approving it. You may still want to leave it up for a little bit more.

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@martinvonz
Copy link
Copy Markdown
Member

Sorry, I had not seen Philip's comment when I approved. I still think this PR is a good improvement. We can add a longer version later if necessary. Does that sound okay?

@PhilipMetzger
Copy link
Copy Markdown
Contributor

We can add a longer version later if necessary. Does that sound okay?

SGTM. To me this is like adding the bare necessities while writing an actual policy can follow later.

@PhilipMetzger
Copy link
Copy Markdown
Contributor

Here is also another nice resource I found recently on AI policies https://github.com/chaoss/wg-ai-alignment/tree/main/moderation#readme which also should be looked at when we'll write the policy.

The goal is to nudge contributors towards taking on the burden of
understanding and editing any AI-generated work they are trying to get
reviewed.

AFAICT, jj is currently less overwhelmed with low-quality AI
contributions than to some other projects, but it started to happen
occasionally.

For now, this is partly an experiment as opposed to a fixed rule. Will
the people who most need this guidance read it and benefit from it?
Hopefully, they'll try to or will ask questions. 

I considered also adding a clarification to the second point, suggesting
something like "If in doubt, delete all the AI-generated text and
rewrite it in your own words", but that point was already getting long.
We could add something like that later.

See #8897 (comment)
for some reasons I didn't want to require disclosing whether people
used AI tools while preparing the PR.
@ilyagr
Copy link
Copy Markdown
Contributor Author

ilyagr commented Mar 3, 2026

Thanks everyone! Sorry for the delay.

I updated the wording, thanks Martin, and added a link to #8897 (comment) to the description.

If I don't hear anything else, I'll merge this tomorrow.

@ilyagr
Copy link
Copy Markdown
Contributor Author

ilyagr commented Mar 3, 2026

Also, thanks Philip for the useful links!

@martinvonz
Copy link
Copy Markdown
Member

Thanks. LGTM

Copy link
Copy Markdown
Contributor

@scott2000 scott2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilyagr ilyagr added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 8294491 Mar 3, 2026
30 checks passed
@ilyagr ilyagr deleted the ig/ai-pr-rules branch March 3, 2026 20:54
@PhilipMetzger
Copy link
Copy Markdown
Contributor

Here's another policy (cilium/community#408) from Cilium which I think is more aligned with the current status quo.

@PhilipMetzger
Copy link
Copy Markdown
Contributor

And another list of policies from the Python community: https://github.com/melissawm/open-source-ai-contribution-policies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants