feat(lance): push LIMIT down into Lance scans#5
Open
jja725 wants to merge 1 commit into
Open
Conversation
PrestoDB has no applyLimit SPI, so add a ConnectorPlanOptimizer that rewrites LIMIT directly above a Lance TableScan into a LanceTableHandle carrying the row count (LanceLimitPushdown + LanceConnectorPlanOptimizerProvider, wired through LanceModule and LanceConnector.getConnectorPlanOptimizerProvider). With a pushed-down limit the split manager coalesces just enough leading fragments to cover it into a single split (deletion-aware via Fragment.metadata().getNumRows()) instead of one-split-per-fragment, and the fragment page source passes ScanOptions.limit(n) to stop each scan early. The engine still enforces the exact count, so this is a best-effort IO reduction. Only fires when LIMIT sits directly over the scan (no intervening FILTER), keeping semantics exact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds LIMIT pushdown to the Presto Lance connector. PrestoDB has no
applyLimitSPI, so this uses aConnectorPlanOptimizer.LanceLimitPushdownrewrites aLimitNodesitting directly over a LanceTableScanNodeinto aLanceTableHandlecarrying the row count (wired viaLanceConnectorPlanOptimizerProvider→LanceModule→LanceConnector.getConnectorPlanOptimizerProvider). Only fires when LIMIT is directly over the scan (no intervening FILTER), so semantics stay exact.Fragment.metadata().getNumRows()) instead of one-split-per-fragment.ScanOptions.limit(n)to stop each scan early.Best-effort IO reduction — the engine still enforces the exact row count.
Test plan
TestLanceLimitPushdown(pushes into scan, idempotent),TestLanceSplitManager(split-per-fragment vs single coalesced split + coalesce helper edge cases), additions toTestLanceTableHandle(limit field + JSON round-trip)../mvnw -o test -pl presto-lance→ 37 tests, BUILD SUCCESS.🤖 Generated with Claude Code