Engine: Fix UTF-8 mojibake (乱码) during streaming#129
Open
leo71233826 wants to merge 1 commit intojjang-ai:devfrom
Open
Engine: Fix UTF-8 mojibake (乱码) during streaming#129leo71233826 wants to merge 1 commit intojjang-ai:devfrom
leo71233826 wants to merge 1 commit intojjang-ai:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical streaming issue where multi-byte UTF-8 characters (e.g., Chinese, Japanese, Emojis) would occasionally render as replacement characters (
\ufffd) when a token boundary splits the character's byte sequence.Motivation
In LLM streaming, a single token might only contain a partial byte sequence of a multi-byte character.
Changes
performOneGenerationPassloop to ensure we only emit complete UTF-8 sequences.NaiveStreamingDetokenizerto avoid emitting partial segments when\ufffdis detected at the end of the decoded string.Verification
Qwen3.6-35B-A3Bon Chinese prompts.\ufffdinside words) is eliminated during high-speed streaming.