Skip to content

Guard default repetition penalty flag for older external engines#77

Open
Rishirandhawa wants to merge 1 commit intojjang-ai:mainfrom
Rishirandhawa:fix/issue-75-repetition-penalty-compat
Open

Guard default repetition penalty flag for older external engines#77
Rishirandhawa wants to merge 1 commit intojjang-ai:mainfrom
Rishirandhawa:fix/issue-75-repetition-penalty-compat

Conversation

@Rishirandhawa
Copy link
Copy Markdown

Fixes #75

Summary

  • detect the resolved local engine version before building session launch args
  • omit --default-repetition-penalty when the app is launching an older external vmlx-engine that predates that CLI flag
  • log a clear upgrade hint instead of hard-failing session startup
  • keep bundled/project-venv engines on the current behavior
  • update the settings-flow test mirror to cover the real default repetition penalty and the legacy-engine compatibility path

Verification

  • npm test -- settings-flow.test.ts
  • npm run typecheck (currently still fails on the pre-existing renderer typing error at panel/src/renderer/src/components/sessions/SessionConfigForm.tsx:937)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

model load error: vmlx-engine: error: unrecognized arguments: --default-repetition-penalty 1.10

1 participant