Fix jev_verify handling of evidence IDs named none - #38
Merged
jkudish merged 1 commit intoSep 26, 2026
Merged
Conversation
jkudish
added a commit
that referenced
this pull request
Sep 26, 2026
jkudish
added a commit
that referenced
this pull request
Sep 26, 2026
Owner
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jev_verifyusesnoneas an internal no-source option when multiple evidence items are supplied. If a caller provides a real evidence item whose ID is alsonone, the internal option overwrites that evidence entry in the choice criteria. A model response selecting the real evidence is then incorrectly returned assupporting_evidence: null.This change:
noneReproduction
Call
jev_verifywith multiple evidence items, including{ id: "none", ... }, and have Jev select that evidence as the claim source. Before this fix, the request criteria replace the realnoneentry with the no-source description and the result loses the selected evidence ID.Verification
npm test— 225/225 passingnpm run typechecknpm run buildgit diff --check