Scroll pane, focus kept across frames, plain input focus - #2
Merged
Merged
Conversation
…rted input focus
yframe scrolls to the focused element, so a pane of plain rows could not be
scrolled and a pane of widgets scrolled wherever focus sat. :scroll scrolls by
rows, follows the bottom until scrolled, takes the wheel over it, and reports
{:top :max :rows} so an app can page it from its own keys.
A frame that rebuilt a container (a new sibling ahead of the focused widget,
or a container created where there was one child) moved the focus to the
first child. The widget that held the focus now gets it back.
The soft-wrapping input no longer renders in reverse video when focused; the
cursor already shows it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
:scroll, a pane that scrolls its subtree by rows (wheel over it, follows the bottom, reports {:top :max :rows}). Keeps the focus on the widget that had it when a frame rebuilds a container. Drops the reverse-video focus style from the soft-wrapping input. Tests in render_test.