docs(guide): drop the raylib-ios screenshots from both guides - #7
Merged
Merged
Conversation
Same cleanup as #5 and #6, extended to the two guide pages, which an earlier grep missed because a zsh glob with no match (docs/guide/*.html, which doesn't exist) aborted the whole command before it reached the .md files that do. - docs/guide/porting-an-example.md: the opening spirograph.png had no caveat of any kind, and the four-image block further down was captioned "running on the phone", stated as fact rather than sibling-build fact. Both are raylib-ios captures. Removed, keeping the factual content each caption carried (screen dimensions, no-new-binding count) as plain text. - docs/guide/performance-on-a-phone.md: this guide's own opening paragraph already says every number came off the sibling build, not Android, which is exactly right, but its two embedded images (spirograph.gif, the penrose/kaleidoscope stills) were never covered by that sentence. Removed both; the numbers in their captions are already in the tables directly below each, so nothing is lost. - docs/site.edn: the :asset-dirs comment claimed docs/images was "referenced from the homepage and the guides", which stopped being true across three separate commits now. Updated to say what's actually there: raylib-ios captures, unreferenced everywhere in this repo's docs, kept configured so an Android capture dropped in later just works. No image files deleted, only what the docs show. A repo-wide grep for images/, .gif and .png across README.md, CONTRIBUTING.md, docs/guide/*.md and docs/templates/*.html now returns nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #5 and #6:
docs/guide/porting-an-example.htmlon the live site still had raylib-ios screenshots, one with no caveat at all and one captioned "running on the phone" as if it were fact. Checking its sibling guide,performance-on-a-phone.md, turned up two more of the same, even though that page's own opening paragraph already says every number came off the sibling build, not Android. The images just weren't covered by that sentence.(These were missed in the earlier passes because a
grep ... docs/guide/*.md docs/guide/*.htmlin this session hit a zsh glob-no-match on*.html, which aborted the whole command before the.mdhalf ever ran. Re-ran it properly this time.)Changes
:asset-dirscomment, which claimed the images were "referenced from the homepage and the guides" — no longer true after this and the last two PRs. Says what's actually there now.A repo-wide grep for
images/,.gifand.pngacross README.md, CONTRIBUTING.md,docs/guide/*.mdanddocs/templates/*.htmlnow returns nothing. No image files deleted, only what the docs show.