Skip to content

fix: run carrier detection load() in executor #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmdevita merged 1 commit into from
Apr 25, 2026
Merged

fix: run carrier detection load() in executor #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions custom_components/parcelapp/carrier_detection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,9 +342,6 @@ def detect(self, tracking_number: str) -> list[CarrierMatch]:

Returns matches sorted by confidence (highest first).
"""
if not self._loaded:
self.load()

results: list[CarrierMatch] = []

for pattern in self._patterns:
Expand Down
2 changes: 1 addition & 1 deletion custom_components/parcelapp/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ async def async_register_services(hass: HomeAssistant):

session = async_get_clientsession(hass)
detector = CarrierDetector()
detector.load()
await hass.async_add_executor_job(detector.load)

async def async_add_parcel(call: ServiceCall):
"""Add a parcel to ParcelApp using the official API."""
Expand Down
Loading