Jm/httpserver #23
Merged
Jm/httpserver #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix match expression syntax in http_server.cap (use explicit returns inside match arms instead of return match) - Add TcpConn::read(max_size) method that reads available bytes without waiting for EOF, which is required for HTTP since clients keep connections open - Update HTTP server to use read(4096) instead of read_to_string() 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Flatten nested matches by inlining expressions - Use single-line match arms for simple cases - Extract handle_request helper to reduce nesting in serve_once - Remove redundant intermediate variables - Use early returns to avoid else branches - Simplify response functions to single return statements Reduces code from 183 to 133 lines while maintaining functionality. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This method discards the error type, allowing Results with different error types to be unified. Useful for propagating errors with ?. Note: Currently has a codegen limitation - cannot be used directly with ? operator due to "unsupported match result value" error. The method works correctly in other contexts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…nit]" This reverts commit 51464c6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.