Use binary file read/write for marshalling#8
Open
coezbek wants to merge 1 commit intojmervine:masterfrom
Open
Conversation
I have used diskcached (with joy) for many years but only now stumbled upon an issue where a serialized hash can't be read again. Looking into the code I found that diskcached doesn't use binary file mode. I believe this is an error and bound to cause issues with newlines (\r\n vs. \r vs. \n) at least under Windows. Could you merge my pull request?
Author
|
I think occurs simply when marshalling an integer such as 13 directly as integer (i.e. not as a string), which causes a read to split the input during reading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have used diskcached (with joy) for many years but only now stumbled upon an issue where a serialized hash can't be read again. Looking into the code I found that diskcached doesn't use binary file mode. I believe this is an error and bound to cause issues with newlines (\r\n vs. \r vs. \n) at least under Windows.
Could you merge my pull request?