refactor: migrate to @jmlweb/tooling packages#10
Merged
Conversation
- Replace custom ESLint config with @jmlweb/eslint-config-base - Replace custom Prettier config with @jmlweb/prettier-config-base - Replace custom tsconfig with @jmlweb/tsconfig-base - Replace custom commitlint config with @jmlweb/commitlint-config - Apply auto-fixes from new stricter linting rules - Add project-specific rule overrides for utility library patterns - Fix for-of loop in makeIsDeepEqual - Fix nullish coalescing in lruCache All 561 tests pass.
|
🎉 This issue has been resolved in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates mochila to use the shared @jmlweb/tooling packages for consistent configuration across projects.
Changes
New Dependencies
@jmlweb/eslint-config-base(replaces custom ESLint config)@jmlweb/prettier-config-base(replaces .prettierrc.json)@jmlweb/tsconfig-base(extends base tsconfig)@jmlweb/commitlint-config(replaces custom commitlint config)Removed
.prettierrc.json(now uses package.json "prettier" field)Code Fixes
forloop →for-ofin makeIsDeepEqual.ts||→??in lruCache.ts (nullish coalescing)Rule Overrides
Added project-specific overrides for utility library patterns:
no-unsafe-*rules (needed for throttle/debounce/pipe)no-empty-function(noop is intentionally empty)Verification
pnpm lintpasses (1 warning)Note
Migrates repo to shared @jmlweb tooling and updates code to satisfy stricter lint/TS rules while keeping behavior unchanged.
@jmlweb/eslint-config-base,@jmlweb/prettier-config-base(viapackage.json),@jmlweb/tsconfig-base, and@jmlweb/commitlint-config; remove.prettierrc.jsonand old commitlint ruleseslint.config.mjs: extend base config, addtsdoc, and introduce targeted rule relaxations plus test-file overridespackage.jsondevDeps/scripts; regeneratepnpm-lock.yamlsrc/: switch toimport type, preferreadonly ...[]overReadonlyArray, refine generics/utility types, and minor refactors (e.g.,for...ofinmakeIsDeepEqual, nullish coalescing inlruCache, small readability tweaks indebounce,lastIndexOf)typealiases, explicit readonly arrays)Written by Cursor Bugbot for commit 6edff38. This will update automatically on new commits. Configure here.