-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade ESLint to version 9 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jmlweb
merged 2 commits into
main
from
claude/upgrade-eslint-v9-011CUpZ8RUD8vgNJvtb9XzUg
Nov 5, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import eslint from '@eslint/js'; | ||
| import prettierConfig from 'eslint-config-prettier'; | ||
| import prettierPlugin from 'eslint-plugin-prettier'; | ||
| import simpleImportSort from 'eslint-plugin-simple-import-sort'; | ||
| import tsdoc from 'eslint-plugin-tsdoc'; | ||
| import globals from 'globals'; | ||
| import tseslint from 'typescript-eslint'; | ||
|
|
||
| export default [ | ||
| // Base ESLint recommended rules | ||
| eslint.configs.recommended, | ||
|
|
||
| // TypeScript ESLint recommended rules | ||
| ...tseslint.configs.recommended, | ||
|
|
||
| // Prettier config (disables conflicting rules) | ||
| prettierConfig, | ||
|
|
||
| // Main configuration | ||
| { | ||
| files: ['**/*.ts', '**/*.tsx'], | ||
| plugins: { | ||
| '@typescript-eslint': tseslint.plugin, | ||
| 'simple-import-sort': simpleImportSort, | ||
| 'tsdoc': tsdoc, | ||
| 'prettier': prettierPlugin, | ||
| }, | ||
| languageOptions: { | ||
| parser: tseslint.parser, | ||
| parserOptions: { | ||
| project: './tsconfig.json', | ||
| }, | ||
| globals: { | ||
| ...globals.node, | ||
| ...globals.es2021, | ||
| }, | ||
| }, | ||
| rules: { | ||
| 'prettier/prettier': 'error', | ||
| 'simple-import-sort/imports': 'error', | ||
| 'simple-import-sort/exports': 'error', | ||
| 'tsdoc/syntax': 'warn', | ||
| }, | ||
| }, | ||
| ]; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Explicit ignores needed in ESLint 9 flat config
The new ESLint 9 flat config is missing an
ignoresconfiguration. ESLint 9 does not automatically respect.eslintignorefiles - ignores must be explicitly configured in the flat config. Without this, ESLint will attempt to lint files indist/,node_modules/,coverage/, and other build artifacts, which can cause errors or significantly slow down linting. The configuration should include an ignores array, e.g.,{ ignores: ['dist/**', 'coverage/**', 'node_modules/**', 'docs/**', '**/*.js', '**/*.mjs', '**/*.cjs'] }as a separate config object at the beginning of the array.