Skip to content

Zone Hint dismissal leaves no residue (integer Overlay Box rects) #4

Open

Description

@jmmon

Parent

Part of #3

What to build

A dismissed Zone Hint leaves zero residual pixels on the Overlay Canvas, on every show→hide cycle. The fps and dev-stats Overlay Boxes likewise leave no residue when their values change length or they close. Achieved by rounding Overlay Box rects at the source — floor the left/top, ceil the right/bottom — via one shared helper, so fill and clear cover pixel-identical regions. Today the Zone Hint's fractional bottom edge (tileSize × 1.6) leaves a faint ~9% black 1px line after every dismissal; fps/dev-stats leave a vertical strip variant.

Acceptance criteria

  • A shared rect-rounding helper exists and is used by the Zone Hint, fps, and dev-stats rect computations; help, help-hint, AFK, and statusbar rects are untouched
  • Unit tests: each of the three rect helpers returns integer left/top/right/bottom for representative viewport widths at tileSize 32, scale 1, and for a fractional scale
  • QA (headless): player enters a zone → Zone Hint screenshot → dismissal → pixel-probe the overlay canvas at the old bottom edge row shows no dark residue; screenshots stored as evidence
  • fps/dev-stats boxes leave no vertical residue when the displayed value length changes
  • Full gate green: unit tests, lint, typecheck, production build

Blocked by

None (can start immediately).

Activity

  1. jmmon commented on Nov 21, 2026

    @jmmon
    OwnerAuthor

    Factory run claimed this issue at 2026-11-21T00:05:42-05:00. Branch: factory/issue-4.

  2. jmmon commented on Nov 21, 2026

    @jmmon
    OwnerAuthor

    Factory run escalated: station spec failed

    [2026-11-21 00:05:40] factory start: issue #4 branch factory/issue-4
    [2026-11-21 00:05:44] station: spec
    [2026-11-21 00:05:44] spec not written (attempt 1): specs/issue-4.md
    [2026-11-21 00:05:44] spec not written (attempt 2): specs/issue-4.md
    [2026-11-21 00:05:44] retro file not written; continuing without it
    [2026-11-21 00:05:44] escalating issue #4: station spec failed
    

    Local logs: factory/logs/issue-4/.

  3. jmmon commented on Nov 21, 2026

    @jmmon
    OwnerAuthor

    Factory run claimed this issue at 2026-11-21T00:06:36-05:00. Branch: factory/issue-4.

  4. jmmon commented on Nov 21, 2026

    @jmmon
    OwnerAuthor

    Factory opened a draft PR: #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions