Skip to content

fix(mcp): prioritize exact match in label name resolution (PUNT-405) #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmynes wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(mcp): prioritize exact match in label name resolution (PUNT-405) #484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7cbcf4
fix(mcp): prioritize exact match in label name resolution (PUNT-405)
jmynes Mar 24, 2026
4a8b696
fix(mcp): add empty-string guard and short-circuit exact match in lab…
jmynes Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions mcp/src/tools/labels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,20 @@ import {
} from '../api-client.js'
import { errorResponse, escapeMarkdown, safeTableCell, textResponse } from '../utils.js'

/**
* Find a label by name using tiered matching: exact match first, then substring fallback.
*/
function findLabelByName<T extends { name: string }>(
labels: T[],
labelName: string,
): T | undefined {
if (!labelName.trim()) return undefined
const nameLower = labelName.toLowerCase()
const exactMatch = labels.find((l) => l.name.toLowerCase() === nameLower)
if (exactMatch) return exactMatch
return labels.find((l) => l.name.toLowerCase().includes(nameLower))
}

/**
* Format a list of labels for display
*/
Expand Down Expand Up @@ -94,9 +108,7 @@ export function registerLabelTools(server: McpServer) {
return errorResponse(listResult.error)
}

const label = listResult.data?.find((l) =>
l.name.toLowerCase().includes(labelName.toLowerCase()),
)
const label = listResult.data ? findLabelByName(listResult.data, labelName) : undefined

if (!label) {
return errorResponse(`Label not found: ${labelName}`)
Expand Down Expand Up @@ -145,9 +157,7 @@ export function registerLabelTools(server: McpServer) {
return errorResponse(listResult.error)
}

const label = listResult.data?.find((l) =>
l.name.toLowerCase().includes(labelName.toLowerCase()),
)
const label = listResult.data ? findLabelByName(listResult.data, labelName) : undefined

if (!label) {
return errorResponse(`Label not found: ${labelName}`)
Expand Down Expand Up @@ -188,9 +198,7 @@ export function registerLabelTools(server: McpServer) {
return errorResponse(labelsResult.error)
}

const label = labelsResult.data?.find((l) =>
l.name.toLowerCase().includes(labelName.toLowerCase()),
)
const label = labelsResult.data ? findLabelByName(labelsResult.data, labelName) : undefined

if (!label) {
return errorResponse(`Label not found: ${labelName}`)
Expand Down Expand Up @@ -257,9 +265,7 @@ export function registerLabelTools(server: McpServer) {
}

// Find the label on the ticket
const label = ticket.labels.find((l) =>
l.name.toLowerCase().includes(labelName.toLowerCase()),
)
const label = findLabelByName(ticket.labels, labelName)

if (!label) {
return errorResponse(
Expand Down
Loading