Clean up repo#17
Closed
jacebenson wants to merge 2 commits into
Closed
Conversation
added 2 commits
October 20, 2017 11:25
…p to get started.
Removed Point Table. Was unused. Removed now unused business rules on `_slack_event` Added methods to SlackClient (log, say, addPoint) Update Endpoint to use SlackClient
Owner
|
Hey @jacebenson, thank you for all of this! If possible, make future Pull Requests small and have them each address one pieces of functionality. I'm working through the diffs here, but lesson learned, this one's a bit too large :) This is a learning process all around but we'll figure out the best way to handle this workflow. More info soon. |
Author
|
No problem. I’ll try to redo this is smaller bits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Clean up application by removing extra things not in use to reduce the commit size.
Abstract logic to script include.
Add property to control to use addPoint feature.
Added tgbates code for alteranating Congratulations messages.
Updated
addPointsso it has a good starting point for people to copy for new featuresRelated PRs
List related PRs against other branches: